Add metadata to missing nodes #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix metadata read write tests
bvogginger
force-pushed
the
metadata_for_all_nodes
branch
from
a53c3e3
to
f23efa0
Compare
bvogginger
commented
Aug 16, 2024
| @@ -1,7 +1,7 @@ | |||
| repos: | |||
| - repo: https://github.com/astral-sh/ruff-pre-commit | |||
| # Ruff version. | |||
| rev: v0.0.277 | |||
| rev: v0.6.0 | |||
There was a problem hiding this comment.
I updated this to version 0.6.0 to have the same behaviour in pre-commit and during the github-actions-build.
bvogginger
commented
Aug 16, 2024
| @@ -49,3 +49,5 @@ find={include = ["nir*"]} | |||
| line-length = 100 | |||
| lint.per-file-ignores = {"docs/conf.py" = ["E402"]} | |||
| exclude = ["paper/"] | |||
| extend-exclude = ["*.ipynb"] | |||
There was a problem hiding this comment.
With version 0.6.0 of ruff, all notebooks are checked by default in ruff.
This lead to errors when checking the spyx example notebook: https://github.com/neuromorphs/NIR/actions/runs/10415679589.
To restore the previous behaviour, I excluded notebooks again.
|
Nice, thanks for the PR @bvogginger, it looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version, not all nodes had the
metadataattribute.Metadata was now added to all missing nodes.
Also the tests for checking the metadata export/import was updated to consider all nodes in the graph.